API/ABI changes review for PCL

[lvc]

The review of API/ABI changes for PCL since 1.1.2 version: https://abi-laboratory.pro/tracker/timeline/pcl/

The report is updated 3 times a week. Hope it will be helpful for users and maintainers of the library.

Created with the help of https://github.com/lvc/abi-tracker.

Thank you.

Environment

• Linux x86_64
• GCC 4.9
• PCL 1.1.2 and higher

[taketwo]

Would be nice to get such a report for the current master to see if we unintentionally made any ABI breaking changes.

[SergioRAgostinho]

I was trying to do it actually. But I was having some troubles, with GCC segfaulting during compilation... Yep... during compilation...

[taketwo]

Oh well...

[SergioRAgostinho]

Managed to get it working with the new abi-dumper method he reports on the website https://lvc.github.io/abi-compliance-checker/#ABI_Dumper

It's on 👍

[SergioRAgostinho]

compat_reports.zip
Freshly brewed

Problem summary:

• libpcl_cuda_sample_consensus - a weird complaint of a remove and added symbol...
• libpcl_gpu_features - same as above
• libpcl_gpu_octree - same as above
• libpcl_gpu_surface - same as above
• libpcl_io - members added to ply reader in PLYReader: thread safe colors #1587
• libpcl_segmentation - virtual destructor Searchpcl::PointXYZ::~Search ( ) is overriden by three kdthree classes (i don't really get this one, there are classes from another module), plus a number of added/removed symbols from flann and boost

[SergioRAgostinho]

Added summary above.

[taketwo]

There were no changes to neither kdtree nor search module since the last release, so we can not do anything about this I guess.

[lvc]

Would be nice to get such a report for the current master to see if we unintentionally made any ABI breaking changes.

Added report for master: https://abi-laboratory.pro/tracker/timeline/pcl/

Build requires a lot of resources, so I will update it once a week or so (not daily).

[SergioRAgostinho]

@taketwo What about adding this to README.md ?

[taketwo]

What exactly would you add? A link to the report? They don't seem to have any badges.

[SergioRAgostinho]

diff --git a/README.md b/README.md
index b09212a..e98a330 100644
--- a/README.md
+++ b/README.md
@@ -41,3 +41,7 @@ Issues
 ------
 For general questions on how to use the PCL, please use the [pcl-users](http://www.pcl-users.org/) mailing list (do not forget to subscribe before posting).
 To report issues, please read [CONTRIBUTING.md#bug-reports](https://github.com/PointCloudLibrary/pcl/blob/master/CONTRIBUTING.md#bug-reports).
+
+API/ABI Compatibility Report
+------
+For details about API/ABI changes over the timeline please check PCL's page at [ABI Laboratory](https://abi-laboratory.pro/tracker/timeline/pcl/).

Edit: Let me see if we can badge it up somehow.

[SergioRAgostinho]

@lvc providing an endpoint/link with an updated badge backwards compatibility | xx% would be the "icing on the cake".

Nevertheless thanks for already lifting this "burden" from us :)