Skip to content

fixed const iterator errors (win64) #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jan 2, 2014
Merged

fixed const iterator errors (win64) #215

merged 1 commit into from Jan 2, 2014

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2013

Fixed errors under Visual Studio 2008, 64bit. Now pcl is compiling again.

@jspricke
Copy link
Member

Could you be more specific on the error? Also, your change break compilation on other systems (see Travis error), could you fix this? Thanks!

@ghost
Copy link
Author

ghost commented Aug 15, 2013

Hi Jochen,
thank you for your hints. I am currently facing more compiler problems with PCL coming from the visualization module and some other, which rely on VTK.
The problems are types, which are not supported by Visual Studio (or some other I could not discover the reason for).
Since there are quite a few, I was wondering if someone else is working with PCL on windows?
Or do I have a chance to get feedback if I post compiler errors here, which I cannot resolve?

I will do my best to keep the compliance with Ubuntu using Travis, however, the builds take some time which will delay the development. (I also dont work every day on pcl).

Cheers

@jspricke
Copy link
Member

  • mojovski [email protected] [2013-08-15 11:52]:

    Since there are quite a few, I was wondering if someone else is working with PCL on windows?

AFAIK it used to work fine with PCL-1.6, maybe you could try a git
bisect, but there have been a lot of commits in between.

Or do I have a chance to get feedback if I post compiler errors here, which I cannot resolve?

I would propose to post to our pcl-users mailing list or have a look at
the archive: http://www.pcl-users.org/.

Cheers Jochen

@rbrusu
Copy link
Member

rbrusu commented Sep 7, 2013

Stefan Holzer is one of our PCL Windows maintainers.

@ghost ghost assigned holzers Oct 2, 2013
rbrusu added a commit that referenced this pull request Jan 2, 2014
fixed const iterator errors (win64)
@rbrusu rbrusu merged commit 0b604cc into PointCloudLibrary:master Jan 2, 2014
@wecacuee
Copy link

wecacuee commented Jan 2, 2014

This breaks the build for me on Ubuntu 12.04 with gcc 4.6.3

@wecacuee
Copy link

wecacuee commented Jan 2, 2014

Actually not all the changes but a missing typename. The following commit fixes it:

wecacuee@93b4e0f

@arjun810
Copy link
Contributor

arjun810 commented Jan 4, 2014

This also breaks building on Mavericks with system clang.

@rbrusu
Copy link
Member

rbrusu commented Jan 4, 2014

would it be possible to submit a pull request with the patch please? Thanks!

@arjun810
Copy link
Contributor

arjun810 commented Jan 4, 2014

It looks like wecacuee submitted a pull request with the same change I made that got this to compile for me:

#425

@rbrusu
Copy link
Member

rbrusu commented Jan 4, 2014

Thanks a lot for the prompt reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants