Modified GlasbeyLUT indexing type to size_t
#2297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, code such as this:
size_t i = 10000;
pcl::RGB color = pcl::GlasbeyLUT::at(i % pcl::GlasbeyLUT::size());
... produces the warning "Parameter type mismatch: Values of type
'size_t' may not fit into the receiver type 'unsigned int'".
Closed
SergioRAgostinho
added
changelog: ABI break
SergioRAgostinho
changed the title
GlasbeyLUT indexing type to size_t
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
1febf00
pcl_visualizer: Fix typo in comment
fe04456
Make GlasbeyLUT at() and size() consistent
Without this, code such as this:
... produces the warning
Parameter type mismatch: Values of type 'size_t' may not fit into the receiver type 'unsigned int'.