Replaced std::fill_n. This command does not work as intended in VS2012 Release Mode #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 Release Mode. The std::fill_n command appears to have no effect in VS2012 Release Mode. This caused a crash in pcl_viewer and other examples based on pcl_visualization on Windows with VS2012.
|
Awesome fix, thanks oskotheim ! |
rbrusu
added a commit
that referenced
this pull request
Sep 16, 2013
Replaced std::fill_n. This command does not work as intended in VS2012 Release Mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std::fill_n command appears to have no effect in VS2012 Release Mode (perhaps it gets optimized away?)
This caused a crash in pcl_viewer and other examples based on pcl_visualization on Windows with VS2012 due to cells with an arbitrary number of points.