NURBS Cylinder Fit Axis Initialization #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Eigen::Vector3d mean; | ||
|
|
||
| unsigned s = unsigned (data->interior.size ()); | ||
| mean = NurbsTools::computeMean(data->interior); |
There was a problem hiding this comment.
Could you add a space in front of the bracket, so it's conforming to the PCL coding style? Thanks!
|
@jspricke thanks! Fixed. |
|
@mszarski would be great to have a unit test, otherwise I'm fine with merging this. |
|
It looks like none of the NURBS classes have unit tests. When I have a block of time I will look at contributing some. At the very least PCL should have an example of the FittingCylinder class which it doesn't currently. I'll work on that next. |
jspricke
added a commit
that referenced
this pull request
Oct 7, 2013
NURBS Cylinder Fit Axis Initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to specify the axes to use for the nurbs cylinder fit.
The first axis provided is used as the clamped (cylinder) axis, while the other two define a plane on which control points are distributed periodically in a circle. This is helpful when the cylinder radius is larger than the point spread in the axis direction.