Clears inlier indices if save_inliers_ is true so that the same rejector... #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor instance can be used in different runs. Side note: user code checking the returned inlier indices size might be able to detect if consensus was found. Note that without this, when no consensus is found, the filtered correspondences are equal to the input correspondences.
Supervoxel clustering can then be used with XYZ data.
|
should i do two separate pull requests here or what is the status on this? |
jspricke
added a commit
that referenced
this pull request
Oct 26, 2013
Clears inlier indices if save_inliers_ is true so that the same rejector...
|
Hi Aitor, thanks for the contribution, I think both are fine. Make them two pull requests next time would be good though, as it would allow us to discuss and accept/reject them separately. |
|
Jochen, thanks! Yes, to be honest, it was a mistake from my side... next time i will know better... cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instance
can be used in different runs. Side note: user code checking the returned inlier indices size
might be able to detect if consensus was found. Note that without this, when no consensus is found,
the filtered correspondences are equal to the input correspondences.