fix to support android cross compile #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # define pcl_isnan(x) isnan(x) | ||
| # define pcl_isfinite(x) isfinite(x) | ||
| # define pcl_isinf(x) isinf(x) | ||
| # define pcl_isnan(x) std::isnan(x) |
There was a problem hiding this comment.
Did something change in a newer NDK? This was working fine until now.
There was a problem hiding this comment.
Yes, something changed. Newer NDK like r9, r9b and r9c produce the following error:
/home/rafael/pcl-superbuild/build/CMakeExternals/Source/pcl/common/include/pcl/pcl_macros.h:105:36: error: 'isfinite' was not declared in this scope
# define pcl_isfinite(x) isfinite(x)
^
/home/rafael/pcl-superbuild/build/CMakeExternals/Source/pcl/common/include/pcl/pcl_macros.h:105:36: note: suggested alternative:
In file included from /home/rafael/android-ndk-r9/sources/cxx-stl/gnu-libstdc++/4.8/include/complex:44:0,
from /home/rafael/pcl-superbuild/build/CMakeExternals/Install/boost-android/include/boost/type_traits/is_complex.hpp:12,
from /home/rafael/pcl-superbuild/build/CMakeExternals/Install/boost-android/include/boost/type_traits.hpp:47,
from /home/rafael/pcl-superbuild/build/CMakeExternals/Source/pcl/common/include/pcl/register_point_struct.h:65,
from /home/rafael/pcl-superbuild/build/CMakeExternals/Source/pcl/common/include/pcl/point_types.h:44,
from /home/rafael/pcl-superbuild/build/CMakeExternals/Source/pcl/common/src/point_types.cpp:37:
/home/rafael/android-ndk-r9/sources/cxx-stl/gnu-libstdc++/4.8/include/cmath:818:5: note: 'std::isfinite'
isfinite(_Tp __f)
^
rbrusu
added a commit
that referenced
this pull request
Jan 2, 2014
fix to support android cross compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to support android cross compile using latest Android NDK (r9c)