Don't require boost in pkg-config #5110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no boost.pc. Regression of 87e12d1.
larshg
previously approved these changes
Dec 29, 2021
|
Should we add a note not to add it, so it doesnt happen again? |
Yes, I also think a short note would be helpful |
|
Feel free to propose a comment if you think it is helpful :). |
mvieth
reviewed
Jan 4, 2022
mvieth
approved these changes
Jan 5, 2022
kunaltyagi
approved these changes
Jan 5, 2022
larshg
approved these changes
Jan 5, 2022
mvieth
added a commit
to mvieth/pcl
that referenced
this pull request
Apr 5, 2022
Discussed here: PointCloudLibrary#5110
mvieth
added
module: cmake
changelog: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no boost.pc. Regression of 87e12d1.