Skip to content

Conversation

arthurdedeus
Copy link
Contributor

Problem

Traces notebook node was looking a bit unpolished. Let's make it look like Issues notebook node, with the filters/options into node's settings and embed the table.

Changes

  • Move filters and table controls over to Settings component
  • Render traces query using <Query /> component directly to have more flexibility

Before

image

After

image image

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

@arthurdedeus arthurdedeus self-assigned this Oct 14, 2025
@posthog-bot posthog-bot requested a review from daibhin October 14, 2025 18:46
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

github-actions bot commented Oct 14, 2025

Size Change: 0 B

Total Size: 3.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.05 MB

compressed-size-action

@arthurdedeus arthurdedeus force-pushed the chore/llma-notebook-node-adjustments branch from 96c8092 to bed5ba1 Compare October 14, 2025 19:23
@arthurdedeus arthurdedeus requested review from a team and rafaeelaudibert and removed request for a team October 14, 2025 19:23
@daibhin daibhin requested review from a team and removed request for daibhin October 14, 2025 19:43
Copy link
Contributor

@lucasheriques lucasheriques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor, i love colocating stuff

@arthurdedeus arthurdedeus merged commit e9c6fb3 into master Oct 17, 2025
132 of 133 checks passed
@arthurdedeus arthurdedeus deleted the chore/llma-notebook-node-adjustments branch October 17, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants