-
Notifications
You must be signed in to change notification settings - Fork 6
Reorganize visualizer menu and add show-arrows option #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice improvement.
Some small nitpicks, see whether you agree. Otherwise most of them can be ignored.
src/power_grid_model_ds/_core/visualizer/layout/cytoscape_config.py
Outdated
Show resolved
Hide resolved
src/power_grid_model_ds/_core/visualizer/layout/cytoscape_styling.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Co-authored-by: Vincent Koppen <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sonarcloud has some issues, mainly duplicate code in the class names.
Signed-off-by: Thijs Baaijen <[email protected]>
…/vis-switch-menus
Signed-off-by: Thijs Baaijen <[email protected]>
|
Screen.Recording.2025-07-30.at.09.05.15.mov
Note: when you hide arrows and switch back and forth to another menu (e.g. config > legend > config) The arrows will be visible again. Couldn't figure out an easy way to prevent that.
I have some ideas, but they'll require more work. Ah well, good enough for now..
fixes #63