Skip to content

Conversation

Thijss
Copy link
Contributor

@Thijss Thijss commented Jul 30, 2025

Screen.Recording.2025-07-30.at.09.05.15.mov

Note: when you hide arrows and switch back and forth to another menu (e.g. config > legend > config) The arrows will be visible again. Couldn't figure out an easy way to prevent that.
I have some ideas, but they'll require more work. Ah well, good enough for now..

fixes #63

Thijss added 2 commits July 30, 2025 09:02
@Thijss Thijss marked this pull request as ready for review July 30, 2025 07:12
Copy link
Contributor

@vincentkoppen vincentkoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice improvement.
Some small nitpicks, see whether you agree. Otherwise most of them can be ignored.

Thijss and others added 4 commits July 31, 2025 18:02
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Copy link
Contributor

@vincentkoppen vincentkoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Sonarcloud has some issues, mainly duplicate code in the class names.

@Thijss Thijss enabled auto-merge (squash) August 6, 2025 20:08
Copy link

sonarqubecloud bot commented Aug 6, 2025

@Thijss Thijss merged commit 042052b into main Aug 6, 2025
22 checks passed
@Thijss Thijss deleted the feat/vis-switch-menus branch August 6, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Remove arrows in visualzier or make them optional
2 participants