Skip to content

Feature / Rename API tests #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2024
Merged

Feature / Rename API tests #719

merged 3 commits into from
Sep 16, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Member

This PR renames API tests to drop the "c_" and "cpp_" prefix to be more concise.

@Jerry-Jinfeng-Guo
initial commit
09d0b70 
Signed-off-by: Jerry Guo <[email protected]>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the improvement Improvement on internal implementation label Sep 12, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Sep 12, 2024
mgovers
mgovers reviewed Sep 12, 2024
View reviewed changes
mgovers
mgovers reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks OK

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review September 13, 2024 10:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

figueroa1395
figueroa1395 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good to me. However, just to double check, is there anything else to it besides making the naming more consistent? If no, feel free to merge.

@Jerry-Jinfeng-Guo
Copy link
Member Author

Makes sense and looks good to me. However, just to double check, is there anything else to it besides making the naming more consistent? If no, feel free to merge.

Nothing else indeed.

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit fbbc448 Sep 16, 2024
26 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/rename-api-tests branch September 16, 2024 09:47
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo restored the feature/rename-api-tests branch February 12, 2025 11:10
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/rename-api-tests branch February 12, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgovers mgovers mgovers left review comments

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo

Labels

improvement Improvement on internal implementation

Projects

Power Grid Model
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jerry-Jinfeng-Guo @mgovers @figueroa1395