Skip to content

Conversation

Gijsreyn
Copy link
Contributor

PR Summary

This pull request is a minor change to reflect all schemas to current for the securityContext canonical property.

PR Context

Fix #1055

@Gijsreyn Gijsreyn force-pushed the fix-securitycontext-current branch from daef381 to 5a2d999 Compare August 24, 2025 21:03
Copy link
Collaborator

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

It looks like you went through to fix the composed schemas directly.

What we actually want to do is:

  1. Update the following line in schemas/src/config/document.metadata.yaml:

  2. Regenerate the schemas for only the v3* version folders.

We don't want to modify the schemas for 2024/04, because those map to before we canonicalized the casing for enums.

@Gijsreyn Gijsreyn force-pushed the fix-securitycontext-current branch from 5a2d999 to fa9feb1 Compare August 27, 2025 00:38
@Gijsreyn
Copy link
Contributor Author

Hi Mikey,

Thanks for checking the pull request. I was already afraid that I was doing something wrong. I had tried running the build.ps1 script in the schemas directory, but couldn't get it to work. I guess I had the powershell-yaml module installed, rather than the yayaml. Anyway, the steps that I did now:

  1. Change what you suggested in step 1.
  2. Run the build.ps1 script for each v3.* version by modifying the schemas.config.yaml file.

Hope that these are the steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

securityContext default value is invalid
2 participants