Skip to content
This repository was archived by the owner on Feb 24, 2021. It is now read-only.

Test templates using a different casing when cloning DscResource.Tests #431

Closed
johlju opened this issue Aug 10, 2018 · 1 comment · Fixed by #455 or #458
Closed

Test templates using a different casing when cloning DscResource.Tests #431

johlju opened this issue Aug 10, 2018 · 1 comment · Fixed by #455 or #458
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Contributor

johlju commented Aug 10, 2018

When running a unit test, the first thing that happens, if not already exist, is to clone the DscResource.Tests repo into the module root folder. When this happens, the repo is cloned as 'DSCResource.Tests' (upper-case 'DSC') where as in the test framework it is cloned as 'DscResource.Test' (upper-case D, lower-case 'sc').
This can have a problem when using tools that are case sensitive, where one test works in the test framework, but not locally.

I suggest we change the test templates to using the name of the repo 'DscResource.Tests' (upper-case D, lower-case 'sc').

DscResources/Tests.Template/unit_template.ps1

Line 30 in 7d18a71

& git @('clone','https://github.com/PowerShell/DscResource.Tests.git',(Join-Path -Path $script:moduleRoot -ChildPath 'DSCResource.Tests'))

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Aug 10, 2018
@johlju johlju mentioned this issue Aug 10, 2018
Merged
johlju added a commit to johlju/DscResources that referenced this issue Sep 22, 2018
@johlju
Change to Unit test template
3e15cba 
- When cloning DscResource.Tests, it using the same casing on the
  repository folder (issue PowerShell#431)
@johlju johlju mentioned this issue Sep 22, 2018
Merged
7 tasks
@johlju johlju self-assigned this Sep 22, 2018
@johlju johlju added in progress The issue is being actively worked on by someone. and removed good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Sep 22, 2018
johlju added a commit that referenced this issue Sep 24, 2018
@johlju
Changes to Unit test template (#455)
017c33d 
- When cloning DscResource.Tests, it using the same casing on the
  repository folder (issue #431)
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Sep 24, 2018
@johlju
Copy link
Contributor Author

johlju commented Sep 25, 2018

I only fixed the unit test template, this needs to be done for the Integration test template too.

@johlju johlju reopened this Sep 25, 2018
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 25, 2018
@johlju johlju mentioned this issue Sep 25, 2018
Merged
7 tasks
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
1 participant
@johlju