Avoid rendering dead keys (2nd attempt) #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Snaptags this fix seems to be working fine with Neo. Can you please give it another try? |
|
Dead key handling is working perfectly! Thank you for this great fix. |
lzybkr
reviewed
Jun 17, 2019
| // We got an 'OemXXX' ConsoleKey, '\0' key char, and no 'Ctrl' modifier. It's very likely generated by a dead key. | ||
| // We check for 'Ctrl' modifier because it's easy to generate '\0' KeyChar and 'OemXXX' by combinding 'Ctrl' with | ||
| // another special key, such as 'Ctrl+?' and 'Ctrl+;'. | ||
| isDeadKey = (c == '\0') && (consoleKey >= ConsoleKey.Oem1 && consoleKey <= ConsoleKey.Oem102) && !isCtrl; |
There was a problem hiding this comment.
There is a large gap of invalid values in that range - maybe you should use a switch?
You also miss OemClear in that range.
There was a problem hiding this comment.
I only see the OemXXX ConsoleKeys generated for the dead keys that I have inspected so far ... Yes, OemClear is not in that range. I didn't include it only because I didn't see it was generated by the dead keys I have inspected :) I will keep the check as is for now, and change it as needed when there are new dead-key issue reported.
lzybkr
approved these changes
Jun 17, 2019
|
Test run passed with French keyboard layout:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a heuristic check to determine if a key pressing is a dead key. Fix #914
The Win32 API
ToUnicodedoesn't work well with non-natively-supported keyboard layouts, such as the Neo keyboard layout.ToUnicodemaps Neo dead keys to unicode characters incorrectly and results in PSReadLine rendering the dead keys.