Skip to content

Don't crash on CIM classes with no superclass #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 13, 2018
Merged

Don't crash on CIM classes with no superclass #1046

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69fbc5b
Don't crash on CIM classes with no superclass
edyoung Jul 26, 2018
b0a89b0
ReTrigger CI by using better linq variable name
bergmeister Jul 26, 2018
df6cf57
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jul 27, 2018
d1cc71b
add test case
edyoung Aug 26, 2018
4561ccc
incorporate PR feedback
edyoung Sep 6, 2018
52dc8cb
tweak test for linux
edyoung Sep 11, 2018
9480642
use join-path
edyoung Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Rules/UseIdenticalMandatoryParametersDSC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ private IDictionary<string, string> GetKeys(string fileName)

var cimClass = cimClasses?.FirstOrDefault();
var cimSuperClassProperties = new HashSet<string>(
cimClass?.CimSuperClass.CimClassProperties.Select(p => p.Name) ??
cimClass?.CimSuperClass?.CimClassProperties.Select(cimPropertyDeclaration => cimPropertyDeclaration.Name) ??
Enumerable.Empty<string>());

return cimClass?
Expand Down