Adapt release script and documentation due to upgrade to .Net Core 2.0 #870
Conversation
…s is not needed any more due to the upgrade to .Net Core 2.0
| @@ -93,7 +93,6 @@ function New-ReleaseBuild | |||
| try | |||
| { | |||
| remove-item out/ -recurse -force | |||
| dotnet restore | |||
| .\buildCoreClr.ps1 -Framework net451 -Configuration Release -Build | |||
| .\buildCoreClr.ps1 -Framework net451 -Configuration PSV3Release -Build | |||
| .\buildCoreClr.ps1 -Framework netstandard1.6 -Configuration Release -Build | |||
There was a problem hiding this comment.
should this be netstandard2.<something>?
There was a problem hiding this comment.
Why? The idea behind .net standard is to keep the number as low as possible. Unless we need an API that is available only in netstandard2.0, there is no value (the standard itself has nothing to do with the runtime, the runtime is responsible for implementing the standard). But maybe give that we are not running on mobile devices, this is maybe over thinking and netstandard2 might make it easier for development by having more apis available.
There was a problem hiding this comment.
I was thinking that the more we match PowerShell Core the better.
There was a problem hiding this comment.
Ok, I don't mind too much if you prefer that but changing to netstandard2.0 should be done as a separate PR.
The upgrade from the .Net Core 1.0Preview2 to .Net Core 2.0 has missed minor places to adapt:
New-Releasefunction