Update from Pester 4.1.1 to 4.3.1 and use new -BeTrue and -BeFalse operators #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assertions and remove deprecated Should -Not -Throw calls
Tests/Engine/Extensions.tests.ps1
Outdated
| @@ -118,7 +118,7 @@ Describe "AttributeAst extension methods" { | |||
| param($param1, $param2) | |||
| }}.Ast.EndBlock.Statements[0] | |||
| $extNamespace::IsCmdletBindingAttributeAst($funcDefnAst.Body.ParamBlock.Attributes[0]) | | |||
| Should -Be $true | |||
| Should BeTrue | |||
There was a problem hiding this comment.
should this be -BeTrue?
There was a problem hiding this comment.
Yes! Thanks, I fixed it.
|
as soon as ci completes successfully, I'll merge |
|
@JamesWTruher On the branch commit and the one that got merged into development, the WMF4 build got cancelled, see here. I assume that was a manual action or is there a problem with the image? I saw that many repos with custom images or ci machines (like e.g. Pester) currently have problems due to the recent breaking change by GitHub that requires the latest update of the Windows Git client. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Pester released 2 new versions this week with new assertion operators.
Should -Be $trueto new operatorShould BeTrueand similar forShould BeFalsethat were added in 4.2Should -Not -Throwgot officially deprecated in 4.2 -> remove assertion because when an exception is thrown, it automatically means that the test should not pass as recommended in the Pester release notes-HaveCountoperator (yet) because existing tests need adaption (and I also suspect a bug in the new operator I raised the first issue here). This also keeps the diff relatively small.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready