Skip to content

Fix AvoidDefaultValueForMandatoryParameter documentation, rule and tests #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Feb 25, 2018

PR Summary

Fixed #876

  • The documentation was not updated when the PSProvideDefaultParameterValue was changed to PSAvoidDefaultValueForMandatoryParameter (see issue)
  • Fix Implementation not alwasy warn, even when not using CmdletBinding
  • Existing tests were questionable -> complete refactoring

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • [ x Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking. There will be warnings (by design) where there were not warnings but this is by design and therefore not a breaking change.
  • Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@JamesWTruher JamesWTruher merged commit 30eb91a into PowerShell:development Feb 26, 2018
@LaurentDardenne
Copy link

The changelog.md file has not been modified, will it be done later?

@bergmeister
Copy link
Collaborator Author

I think the changelog gets only updated with all PRs at release time (which should hopefully be soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvoidDefaultValueForMandatoryParameter: The documentation is wrong
3 participants