-
Notifications
You must be signed in to change notification settings - Fork 393
Update Newtonsoft.Json NuGet package of Rules project from 9.0.1 to 10.0.3 #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Newtonsoft.Json NuGet package of Rules project from 9.0.1 to 10.0.3 #937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PSCore seems to be on 10.0.3, do you think we'll have problems if we get out ahead of that?
Good point. PSScriptAnalyzer should in an ideal world not behave any different if different versions of PowerShell use different versions of |
…erShell due to the current problem of loading multiple assembly version in pscore
…nalyzer into NewtonSoftDotJson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Summary
Update Newtonsoft.Json NuGet package of Rules project from 9.0.1 to 10.0.3 to ensure we have all the latest fixes and match the version of PsCore.
Version
11.0.1
got recently released but we want to bump the version only together with PowerShell when the next version gets released.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets. Please mark anything not applicable to this PRNA
.NA
Make sure you've added a new test if existing tests do not effectively test the code changedWIP:
to the beginning of the title and remove the prefix when the PR is ready