-
Notifications
You must be signed in to change notification settings - Fork 393
Fix New-Release cmdlet by also building also for v4 and misc. improvements #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix New-Release cmdlet by also building also for v4 and misc. improvements #996
Conversation
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV3Release -Build | ||
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV4Release -Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The essential bug was that it was not being built for version 4, the rest is just re-ordering that it builds v 3,4,5,6 in order for better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 1.16.1 version of Script Analyzer did not include a PSv4 directory. So we haven't shipped it for a long while. Has there been an issue with this? Is there any strong reason why we should start shipping a v4 version when we haven't previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should release a v4 version
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV3Release -Build | ||
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV4Release -Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 1.16.1 version of Script Analyzer did not include a PSv4 directory. So we haven't shipped it for a long while. Has there been an issue with this? Is there any strong reason why we should start shipping a v4 version when we haven't previously?
@JamesWTruher we already used to ship a folder for psv34 (and fullclr and coreclr) but PR #919 that fixed the references to SMA to be correct, split v3 and v4 (leading to much better behaviour for v3). The psm1 file has custom code here to pick the right binaries for the right version. PSSA will not work on v4 without this PR |
PR Summary
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets. Please mark anything not applicable to this PRNA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready