Skip to content

Add an explicit manual stage for changelog update #19551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Apr 20, 2023

PR Summary

Fix #19545

Add an explicit manual stage for changelog update.
The step "create GitHub Draft release" requires the corresponding changelog file gets updated for the release. So, add an explicit manual step before the "Create GitHub draft release" stage in the release pipeline to make the dependency clear.

I have run a release pipeline to validate this change:

image

@ghost ghost assigned PaulHigin Apr 20, 2023
@daxian-dbw daxian-dbw marked this pull request as ready for review April 20, 2023 19:10
@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned PaulHigin Apr 20, 2023
@daxian-dbw daxian-dbw added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.2.x-Consider labels Apr 20, 2023
@ghost
Copy link

ghost commented Jun 27, 2023

🎉v7.2.12 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jun 27, 2023

🎉v7.3.5 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Create GitHub draft release" stage depends on changelog update to be merged
4 participants