Initial MSI authoring for Previews #521
Conversation
|
Still need to wire up some UI and hook this into the build, but this MSI should be complete. I have, however, been unable to test this. I need libcrypto.dll and hoping a PR build might build it so I can get a binary without having to clone OpenSSL and build it myself. |
|
Seems Seen this before? Looking through the PR I can't see what else might've affected it. |
|
@heaths could you rebase and resolve the merge conflict please? |
| </Component> | ||
| <Component> | ||
| <File Name="sshd_config_default"> | ||
| <PermissionEx Sddl="O:BAG:SYD:PAI(A;;FA;;;SY)(A;;FA;;;BA)" /> |
There was a problem hiding this comment.
We can have read permissions to the authorized users.
There was a problem hiding this comment.
This was copied from the scripts at the time of writing. Have they changed?
| # Use VS2019 or VS2017 build tools if installed. | ||
| if (-not (Test-Path $sdkPath)) | ||
| { | ||
| $packageName = "windows-sdk-8.1" |
There was a problem hiding this comment.
@tgauth, can you please cross check if windows SDK 8.1 is required?
With your recent telemetry changes, we are using windows SDK 10?
There was a problem hiding this comment.
Yes, the telemetry changes do require windows SDK 10, for the tracelogging header files.
@heaths, is windows SDK 8.1 a requirement for this?
Also - the initial merge conflict was caused by changes I made to the build script for telemetry, so I can help resolve to make sure all changes get incorporated.
There was a problem hiding this comment.
No. This was based on the script at the time but this PR has been open and unmerged for a long time. IMO, would've been better to merge it and add the UI later so any changes to other source would've been accounted for.
PowerShell/Win32-OpenSSH#1484