Skip to content

make env vars optional for default allow list path #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2025
Merged

make env vars optional for default allow list path #757

merged 3 commits into from
Jan 7, 2025

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Oct 14, 2024 •
edited
Loading

PR Summary

  • remove fatal() calls if either env:ProgramFiles and env:ProgramFiles(X86) is not present (and allow list is not configured with -P), and instead fallback on initializing an empty allow list
  • lowercase provider paths before match_pattern_list() to prevent false negatives

PR Context

@tgauth tgauth requested a review from anmenaga October 16, 2024 19:21
@tgauth tgauth requested a review from vthiebaut10 October 21, 2024 17:57
vthiebaut10
vthiebaut10 reviewed Jan 6, 2025
View reviewed changes
@tgauth tgauth merged commit 7baad0a into PowerShell:latestw_all Jan 7, 2025
4 checks passed
@tgauth tgauth deleted the fix-default-allow-list branch January 7, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthiebaut10 vthiebaut10 vthiebaut10 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v9.8.1.0 x86 MSI install / ssh-agent startup failure
2 participants
@tgauth @vthiebaut10