Update to maml rendered to pad example titles issue #119

[BernieWhite]

• MAML generation now pads example titles with dash (-) to improve readability Example names normalization #119

Fix #119

[BernieWhite]

@vors Full loop tests on Add-Member fail, which is expected based on help for Add-Member doesn't include dashed example titles.

Didn't want to change the test, because it is correct. What do you think?

[BernieWhite]

Nit fix :)

[BernieWhite]

Nit fix :)

[vors]

Didn't want to change the test, because it is correct. What do you think?

I think we need green build before we can merge it :)

Let's just change the test to stripe out the padding on example header comparison.

[vors]

Awesome, just 1 comment. Since we are auto-adding padding in maml now, we should stripe it of in the Update-MarkdownHelp and New-MarkdownHelp. Beware, this can be a little tricky. I think the update scenario may not use the maml model reflection at all, but we should include stripping it out, because there is a lot of existing platyPS markdown help that inconsistently uses it. The new-markdownhelp definitely uses the reflection model and we should stipe it out there too.

[BernieWhite]

@vors Yes, actually I see why we would need to update the tests anyway. Otherwise every commit after until Add-Member help is updated would fail.

Good idea. I'll add tests for that and we'll see how it goes.

So just confirming that I've understood correctly. In the New-MarkdownHelp and Update-MarkdownHelp scenarios if a dash padded header has been used we'll simplify example titles in markdown to remove the dashes.

[vors]

Correct.

The update-markdown scenario is fine, because we simply take the markdown part as is:

platyPS/src/Markdown.MAML/Transformer/MamlModelMerger.cs

Lines 65 to 66 in 16a5f68

	// All examples come only from strtringModel
	result.Examples.AddRange(stringModel.Examples);

[vors]

👏