Skip to content

Routes project refactor #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Routes project refactor #80

wants to merge 20 commits into from

Conversation

petak5
Copy link
Member

@petak5 petak5 commented Jul 3, 2020

No description provided.

@petak5 petak5 added this to the Release 1.0 milestone Jul 3, 2020
@petak5 petak5 marked this pull request as ready for review July 3, 2020 13:59
@petak5 petak5 requested review from a user, cgeopapa and marter11 July 9, 2020 20:48
This was linked to issues Jul 9, 2020
Remove ids from **project** update and delete routes #68
Open
Rename projects routes to project #70
Open
Return more detailed response from controllers #72
Open
cgeopapa
cgeopapa reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@cgeopapa cgeopapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/api/controllers/userController.py changes will make conflicts with the input-validation branch changes

src/api/controllers/projectController.py
Comment on lines +17 to +19
userHasProject = UserHasProject(role=1)
userHasProject.project = project
userHasProject.user = user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userHasProject table is not filled automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the example in the documentation: https://docs.sqlalchemy.org/en/13/orm/basic_relationships.html#association-object

Didn't find any other way to create the relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgeopapa cgeopapa cgeopapa left review comments

@marter11 marter11 Awaiting requested review from marter11

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 1.0

Development

Successfully merging this pull request may close these issues.

Return more detailed response from controllers Rename projects routes to project Remove ids from **project** update and delete routes

2 participants

@petak5 @cgeopapa