Skip to content

Compose compiler functionality #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Compose compiler functionality #5450

wants to merge 4 commits into from

Conversation

atbenmurray
Copy link
Contributor

Signed-off-by: Ben Murray [email protected]

Description

This PR adds the compose compiler functionality as discussed in #4855.

The ComposeCompiler takes a list of user-defined transforms and "compiles" them for lazy compilation. This is done as an
alternative to Compose and other classes manipulating a list of transforms on a call by call basis.

The ComposeCompiler does the following:

  • adds Apply instances to the appropriate locations in a list of lazy transforms (required for lazy resampling)
  • adds MultiSampleTransform instances to a list of transforms for memory efficient computation (required for lazy resampling)
  • adds CachedTransform instances to a list of transforms as a potential replacement mechanism for the current CachedDataset / PersistentDataset implementations

This PR doesn't change any user-facing functionality by itself as lazy resampling has not been integrated into Compose / Array and Dictionary transforms; this will follow in subsequent PR(s)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@atbenmurray atbenmurray requested a review from Nic-Ma November 2, 2022 12:08
@atbenmurray atbenmurray self-assigned this Nov 2, 2022
@wyli wyli closed this Mar 17, 2023
@wyli wyli deleted the lr_compose_compile branch March 17, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants