Skip to content

Change type of qto_xyz to ndarray #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

badayvedat
Copy link

Fix model inference error due to unknown type of parameter qto_xyz with Dicom files

Description

In the OHIF labeler, when model inference is started, Dicom files raise an error due to the unknown type of qto_xyz. This PR fixes this by converting the type of qto_xyz to numpy ndarray.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor

wyli commented Dec 8, 2022

I think that's addressed by #5433. or please create a ticket to describe how to reproduce the issue on the Dev branch.

@badayvedat
Copy link
Author

@wyli Thanks! Yes you are right, your PR seems to cover this issue.

@badayvedat badayvedat closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants