Skip to content

Revert "Ability to switch temporary storage to use either memory or d… #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mocsharp
Copy link
Collaborator

Description

Fixes #154

  • Added new configurations (tempStorageLocation) to enable users to use either Memory or Disk (default) for storing incoming data.
  • For disk option:
    • users must configure bufferRootPath.
    • bufferSize allows users to set disk buffer size with a default value of 128KB
  • For Memory option:
    • GC.Collect is called upon a successful upload to force the garbage collector to compact the LOH

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp self-assigned this Sep 23, 2022
@mocsharp mocsharp closed this Sep 23, 2022
@mocsharp mocsharp deleted the revert-166-vchang/temp-storage-switch branch October 11, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigation: Performance with uploading instances to MinIO
1 participant