Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Oct 4, 2022

Description

Fixes #195

Adds the following APIs

  • PUT /config/source/
  • PUT /config/destination/

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Oct 4, 2022
@mocsharp mocsharp added this to the 0.3.2 milestone Oct 4, 2022
@mocsharp mocsharp self-assigned this Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #197 (4d25fdf) into develop (566ba8b) will increase coverage by 0.11180%.
The diff coverage is 98.78935%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #197         +/-   ##
===================================================
+ Coverage   92.90048%   93.01228%   +0.11180%     
===================================================
  Files            271         271                 
  Lines          15494       15885        +391     
  Branches         823         828          +5     
===================================================
+ Hits           14394       14775        +381     
- Misses           845         853          +8     
- Partials         255         257          +2     
Flag Coverage Δ
unittests 93.01228% <98.78935%> (+0.11180%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...formaticsGateway/Services/Http/MonaiHealthCheck.cs 88.88889% <ø> (ø)
.../InformaticsGateway/Test/Shared/DicomScpFixture.cs 87.17949% <ø> (ø)
...ormaticsGateway/Services/Scp/ScpServiceInternal.cs 75.34247% <80.00000%> (+1.42943%) ⬆️
...csGateway/Services/Http/SourceAeTitleController.cs 92.00000% <92.00000%> (-0.15686%) ⬇️
...eway/Services/Http/DestinationAeTitleController.cs 92.07921% <92.30769%> (-0.02605%) ⬇️
src/CLI/Commands/DestinationCommand.cs 98.94737% <100.00000%> (+0.25456%) ⬆️
src/CLI/Commands/SourceCommand.cs 98.69281% <100.00000%> (+0.38772%) ⬆️
src/CLI/Test/DestinationCommandTest.cs 100.00000% <100.00000%> (ø)
src/CLI/Test/SourceCommandTest.cs 100.00000% <100.00000%> (ø)
src/Client/Services/AeTitle{T}Service.cs 95.55556% <100.00000%> (+0.68376%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566ba8b...4d25fdf. Read the comment docs.

@mocsharp mocsharp merged commit 358f400 into develop Oct 5, 2022
@mocsharp mocsharp deleted the gh-195 branch October 5, 2022 14:59
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.2 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to update destinations via PUT request
2 participants