Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Oct 7, 2022

Description

Fixes #202

  • configures sqlite indexes for frequently used queries
  • removes payloads that are in Created state at startup
  • stops storing file metadata that are in the upload queue to speed up performance

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Oct 7, 2022
@mocsharp mocsharp added this to the 0.3.2 milestone Oct 7, 2022
@mocsharp mocsharp self-assigned this Oct 7, 2022
@mocsharp mocsharp changed the base branch from develop to gh-181 October 7, 2022 15:11
@mocsharp mocsharp force-pushed the vchang/gh-202 branch 2 times, most recently from 9ef59ea to fe4d5c3 Compare October 10, 2022 18:29
@mocsharp mocsharp changed the base branch from gh-181 to develop October 11, 2022 16:00
- remove payloads that are in Created state at startup

Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
Copy link
Collaborator Author

All licensing approvals to be done in #198

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #203 (0c657cc) into develop (e9c45fe) will decrease coverage by 0.11604%.
The diff coverage is 82.51748%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #203         +/-   ##
===================================================
- Coverage   92.98026%   92.86422%   -0.11604%     
===================================================
  Files            271         273          +2     
  Lines          15955       16158        +203     
  Branches         831         829          -2     
===================================================
+ Hits           14835       15005        +170     
- Misses           861         897         +36     
+ Partials         259         256          -3     
Flag Coverage Δ
unittests 92.86422% <82.51748%> (-0.11604%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ase/Migrations/20220802200605_R3_0.3.0.Designer.cs 100.00000% <ø> (ø)
src/Database/Migrations/20220802200605_R3_0.3.0.cs 66.66667% <ø> (ø)
...grations/InformaticsGatewayContextModelSnapshot.cs 0.00000% <0.00000%> (ø)
src/InformaticsGateway/Common/PayloadExtensions.cs 93.22034% <ø> (-0.45056%) ⬇️
...ces/Connectors/PayloadNotificationActionHandler.cs 80.82192% <ø> (-0.19074%) ⬇️
...Connectors/PayloadNotificationActionHandlerTest.cs 100.00000% <ø> (ø)
...y/Test/Services/Storage/ObjectUploadServiceTest.cs 100.00000% <ø> (ø)
src/Database/Migrations/20221010184458_R3_0.3.2.cs 50.00000% <50.00000%> (ø)
...icsGateway/Services/Storage/ObjectUploadService.cs 59.63303% <52.17391%> (-2.97568%) ⬇️
...aticsGateway/Services/Storage/ObjectUploadQueue.cs 76.92308% <71.42857%> (-11.96582%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c45fe...0c657cc. Read the comment docs.

@mocsharp mocsharp merged commit 908eeaf into develop Oct 11, 2022
@mocsharp mocsharp deleted the vchang/gh-202 branch October 11, 2022 21:12
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.2 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure sqlite indexes
2 participants