Skip to content

Add support for MongoDB #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 17, 2022
Merged

Add support for MongoDB #238

merged 14 commits into from
Nov 17, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 4, 2022

Description

Fixes #235 .

Add support for using MongoDB. Allows users to pick between MongoDB or sqlite.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Nov 4, 2022
@mocsharp mocsharp added this to the 0.3.4 milestone Nov 4, 2022
@mocsharp mocsharp self-assigned this Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #238 (6706175) into develop (cd14949) will decrease coverage by 5.33766%.
The diff coverage is 63.54430%.

❗ Current head 6706175 differs from pull request most recent head a6796cd. Consider uploading reports for the commit a6796cd to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #238         +/-   ##
===================================================
- Coverage   87.15273%   81.81507%   -5.33766%     
===================================================
  Files            276         304         +28     
  Lines          16198       17553       +1355     
  Branches         835         883         +48     
===================================================
+ Hits           14117       14361        +244     
- Misses          1822        2921       +1099     
- Partials         259         271         +12     
Flag Coverage Δ
unittests 81.81507% <63.54430%> (-5.33766%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/BaseApplicationEntity.cs 85.71429% <0.00000%> (-14.28571%) ⬇️
src/CLI/Logging/ConsoleLoggerFactoryExtensions.cs 0.00000% <0.00000%> (ø)
src/CLI/Services/ConfirmationPrompt.cs 0.00000% <0.00000%> (ø)
src/CLI/Services/EmbeddedResource.cs 0.00000% <0.00000%> (ø)
src/Database/Api/DatabaseException.cs 0.00000% <0.00000%> (ø)
src/Database/DatabaseMigrationManager.cs 0.00000% <0.00000%> (ø)
...ork/Configuration/InferenceRequestConfiguration.cs 100.00000% <ø> (ø)
...abase/EntityFramework/InformaticsGatewayContext.cs 100.00000% <ø> (ø)
...ntityFramework/InformaticsGatewayContextFactory.cs 0.00000% <0.00000%> (ø)
...ork/Migrations/20221116172042_R3_0.3.4.Designer.cs 0.00000% <0.00000%> (ø)
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd14949...a6796cd. Read the comment docs.

@mocsharp mocsharp changed the title Add support for MongoDB Refactor DB code to prepare MongoDB support Nov 8, 2022
@mocsharp mocsharp changed the title Refactor DB code to prepare MongoDB support Add support for MongoDB Nov 8, 2022
Base automatically changed from gh-235 to develop November 8, 2022 18:50
@mocsharp mocsharp changed the base branch from develop to vchang/e2e November 8, 2022 23:34
Base automatically changed from vchang/e2e to develop November 10, 2022 17:49
@mocsharp mocsharp force-pushed the gh-235-mongo branch 8 times, most recently from 87d58c5 to a121ac1 Compare November 16, 2022 16:43
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp force-pushed the gh-235-mongo branch 5 times, most recently from 6706175 to b3a3b6c Compare November 17, 2022 17:55
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit ff677ce into develop Nov 17, 2022
@mocsharp mocsharp deleted the gh-235-mongo branch November 17, 2022 18:24
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.4 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace SQLite with MongoDB
3 participants