Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Dec 21, 2022

Description

The previous build 0.3.6 is DOA due to a merge error.
This fixes the database health check registration logic.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the bug Something isn't working label Dec 21, 2022
@mocsharp mocsharp added this to the 0.3.7 milestone Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #301 (3267c0c) into develop (7d5ab79) will decrease coverage by 0.00513%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #301         +/-   ##
===================================================
- Coverage   81.95435%   81.94922%   -0.00514%     
===================================================
  Files            323         323                 
  Lines          19495       19495                 
  Branches         918         919          +1     
===================================================
- Hits           15977       15976          -1     
+ Misses          3208        3205          -3     
- Partials         310         314          +4     
Flag Coverage Δ
unittests 81.94922% <100.00000%> (-0.00514%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Database/DatabaseManager.cs 37.14286% <ø> (+5.71428%) ⬆️
src/InformaticsGateway/Services/Http/Startup.cs 75.26882% <100.00000%> (-1.07527%) ⬇️
...maticsGateway/Services/HealthLevel7/MllpService.cs 77.17391% <0.00000%> (-2.17392%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5ab79...3267c0c. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 4c15c46 into develop Dec 21, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.7 🎉

The release is available on:

mocsharp added a commit that referenced this pull request Jun 27, 2025
* Register database health check

* Update dependency decisions

Signed-off-by: Victor Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants