Skip to content

Conversation

neildsouth
Copy link
Contributor

@neildsouth neildsouth commented Aug 8, 2023

Description

Fix #422, #424
Implementing the import/export plugins for external Appstuff.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #429 (9ab118b) into develop (f45656b) will increase coverage by 0.49724%.
Report is 1 commits behind head on develop.
The diff coverage is 84.81760%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #429         +/-   ##
===================================================
+ Coverage   79.54818%   80.04542%   +0.49723%     
===================================================
  Files            343         379         +36     
  Lines          21646       23779       +2133     
  Branches         981        1088        +107     
===================================================
+ Hits           17219       19034       +1815     
- Misses          4103        4377        +274     
- Partials         324         368         +44     
Flag Coverage Δ
unittests 80.04542% <84.81760%> (+0.49723%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Api/PlugIns/SR.cs 100.00000% <ø> (ø)
...rc/Api/Test/Storage/FhirFileStorageMetadataTest.cs 100.00000% <ø> (ø)
src/CLI/Services/ConfigurationService.cs 100.00000% <ø> (ø)
src/CLI/Test/ConfigurationOptionAccessorTest.cs 100.00000% <ø> (ø)
...rc/CLI/Test/NLogConfigurationOptionAccessorTest.cs 100.00000% <ø> (ø)
src/CLI/Test/ProgramTest.cs 100.00000% <ø> (ø)
src/Client/Services/AeTitle{T}Service.cs 92.72727% <ø> (ø)
src/Database/DatabaseMigrationManager.cs 0.00000% <0.00000%> (ø)
...ork/Configuration/InferenceRequestConfiguration.cs 100.00000% <ø> (ø)
...tyFramework/Migrations/20230327190827_R3_0.3.15.cs 0.00000% <ø> (ø)
... and 124 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a2c37...9ab118b. Read the comment docs.

@mocsharp mocsharp added the feature A new feature label Aug 16, 2023
@mocsharp mocsharp added this to the 0.4.0 milestone Aug 16, 2023
Signed-off-by: Neil South <[email protected]>
@mocsharp mocsharp force-pushed the nds/#422 branch 2 times, most recently from fb6f764 to 1311753 Compare August 19, 2023 04:27
- New APIs to allow plug-in projects to extend database setups and configurations
- Add integration test feature for end-to-end RemoteAppExecution
- Rename Plugin to PlugIn

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp self-requested a review August 19, 2023 05:57
@neildsouth neildsouth merged commit 2eacbce into develop Aug 22, 2023
@neildsouth neildsouth deleted the nds/#422 branch August 22, 2023 15:59
@mocsharp mocsharp added build Build & build workflow and removed feature A new feature labels Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build & build workflow
Projects
Development

Successfully merging this pull request may close these issues.

Data Export Plugin: Data De-identifier
2 participants