Skip to content

gh-511 Refactor database connection settings in configuration files #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jun 25, 2025

Description

Fixes #511.

Updated the structure of the database connection settings in setup.md, appsettings.Development.json, and appsettings.mongodb.json to include a new "DatabaseOptions" section. This section now contains the "DatabaseName" and a "retries" configuration with specified delay values.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Updated the structure of the database connection settings in setup.md, appsettings.Development.json, and appsettings.mongodb.json to include a new "DatabaseOptions" section. This section now contains the "DatabaseName" and a "retries" configuration with specified delay values.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp added this to the 0.5.2 milestone Jun 25, 2025
@mocsharp mocsharp requested a review from MMelQin June 25, 2025 17:00
@mocsharp mocsharp self-assigned this Jun 25, 2025
Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocsharp mocsharp merged commit 93cc3e1 into develop Jun 25, 2025
27 of 29 checks passed
@mocsharp mocsharp deleted the vchang/mongo-db branch June 25, 2025 23:23
mocsharp added a commit that referenced this pull request Jun 27, 2025
…527)

Updated the structure of the database connection settings in setup.md, appsettings.Development.json, and appsettings.mongodb.json to include a new "DatabaseOptions" section. This section now contains the "DatabaseName" and a "retries" configuration with specified delay values.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp added the bug Something isn't working label Jun 28, 2025
Copy link

🎉 This issue has been resolved in version 0.5.2 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB client connection string not parsed correctly any more
2 participants