Skip to content

Update dependency decisions & fix warnings #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

mocsharp
Copy link
Contributor

@mocsharp mocsharp commented Jan 11, 2023

Description

Update dependency decisions & fix warnings

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp mocsharp added dependencies Pull requests that update a dependency file build labels Jan 11, 2023
@mocsharp mocsharp requested a review from neildsouth January 11, 2023 19:19
@mocsharp mocsharp self-assigned this Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #27 (c70c131) into develop (ef0ae57) will decrease coverage by 0.28090%.
The diff coverage is 66.66667%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #27         +/-   ##
===================================================
- Coverage   97.75281%   97.47191%   -0.28091%     
===================================================
  Files             12          12                 
  Lines            356         356                 
  Branches          36          37          +1     
===================================================
- Hits             348         347          -1     
  Misses             7           7                 
- Partials           1           2          +1     
Flag Coverage Δ
unittests 97.47191% <66.66667%> (-0.28091%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ication/Middleware/BasicAuthorizationMiddleware.cs 96.42857% <50.00000%> (-3.57144%) ⬇️
...entication/Configurations/AuthenticationOptions.cs 100.00000% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef0ae57...c70c131. Read the comment docs.

@mocsharp mocsharp added this to the 0.1.4 milestone Oct 2, 2023
@mocsharp mocsharp merged commit 758ccea into develop Oct 2, 2023
@mocsharp mocsharp modified the milestones: 0.1.4, 1.0.0 Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants