Make workflow-trigger an input to download artifact step
#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-rose
reviewed
Mar 21, 2024
| @@ -75,7 +75,6 @@ jobs: | |||
| uses: dawidd6/[email protected] | |||
| with: | |||
| github_token: ${{ secrets.GITHUB_TOKEN }} | |||
| workflow: trigger-book-build.yaml | |||
There was a problem hiding this comment.
I think this line is needed to identify the workflow that produced the artifact.
There was a problem hiding this comment.
Okay, so it doesn't start a new action. On the portal site, this isn't a workflow though. The workflow that produces the artifact will be in publish-site.yaml. I'll try changing this to be an optional input with the trigger-book-build.yaml as its default value?
There was a problem hiding this comment.
That explains why the error on my fork say "Error: no matching workflow run found with any artifacts?"
There was a problem hiding this comment.
Any other questions I have about the inputs to this step can be answered in the action-download-artifact documentation 🤦♀️
jukent
changed the title
workflow-trigger an input to download artifact step
brian-rose
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unsure on why this step to trigger the build-build lives inside of the book-build. Let me know what you think.
E: Thanks @brian-rose for explaining that it doesn't trigger the trigger-book-build.yaml workflow, but tells the book-build action to look in that action for the artifact.
Related to ProjectPythia/projectpythia.github.io#415 and ProjectPythia/projectpythia.github.io#319