Skip to content

New Portal Landing Page #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Jun 22, 2021
Merged

New Portal Landing Page #115

merged 52 commits into from
Jun 22, 2021

Conversation

kmpaul
Copy link
Collaborator

@kmpaul kmpaul commented Jun 17, 2021

As promised, here is the new landing page for the Portal. I've moved things around to accommodate the new page structure, and that means I had to develop some new text...and I didn't change some old text. It might be that the old text needs to be updated, too.

So, please look closely at the site and all of the contents. Read the text and determine if it makes sense and works with the new layout. Click the links and make sure they work and take you to the right place. Please look at the formatting and decide if it looks clean, the design is good, etc.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 20, 2021

Ok, summarizing the comments so far:

  • @brian-rose: I think the paragraph under the "Project Pythia" heading is too verbose, seeing as it's the first thing people see when they hit the page. I think we can come up something snappier that describes the project in a few short catchphrases, and leave the details to the "About" page

    • @kmpaul: I think we should handle this in a future PR, once the technical aspects of the new theme are in place with this PR.
  • @brian-rose: The "About" page needs updating to better reflect where we are and where we are aiming with our content.

    • @kmpaul: I agree, and I think that should be in another PR.
  • @brian-rose: We recently pushed out a much-revised Contributors Guide on the portal. Can we wrap this in to the new portal?

    • @kmpaul: Yes. I can do that, but I want clarification on whether the /CONTRIBUTING.md file should be updated or removed and which file (/CONTRIBUTING.md vs /content/pages/contributing.md) should be kept (and which one is a copy created at construction time).
  • @brian-rose: I suggest a more prominent link to the Code of Conduct document, it's currently buried pretty deep. Perhaps a third button in the "Contributing" subheading under "Join Us!", along with a mention in that bit of text?

    • @kmpaul: I think I have added this feature with a recent commit. Please check it out in the RTD demo.
  • @andersy005: On smaller screen sizes, the order of sentences in the copyright section is broken

    • @kmpaul: I believe this is fixed, now.
  • @jukent: I would like the gallery card tags to be clickable without opening the modal first.

    • @kmpaul: That's fair. Perhaps we can figure out a way of adding that feature in a future PR (as you suggested).
  • @jukent: I am curious to see the version where the cards are the same size. I know you said it looked bad but I can't picture it looking that bad (is this because there is no "open details" button")

    • @kmpaul: Please confirm that the RTD demo (here) shows the cards all the same size.
  • @jukent: Is the hope that a horizontal card stacking will remove the awkwardness of the cards

    • @kmpaul: I was thinking that. Perhaps we can try that in a future PR that adds the Bootstrap w-100 class to the cards and/or the col-12 class to the column divs of the gallery. Then we can add more content and lay it out differently.
  • @dcamron: Would we look to pull the local theme back out to its repo after some time?

    • @kmpaul: Yes, in a future PR. I figure once the theme has settled down with the existing portal content, then we can pull it out and make it a separate package (in the ProjectPythia/sphinx-pythia-theme repository).

Please check off the items that you feel are satisfactorily answered, and add more comments to address the ones that are not.

@brian-rose
Copy link
Member

@brian-rose: So, the way the old portal was built, it copied the /CONTRIBUTING.md file into the /content/pages/ directory. Are we no longer going to have a /CONTRIBUTING.md file? If we are going to keep one, then we need to make them consistent. ...So, are we going to copy /CONTRIBUTING.md into /content/pages/? Or are we going to copy the one in /content/pages/ into /? (Normally, there is a /CONTRIBUTING.md file.)

Let me check up on this. @clyne led the recent effort to consolidate the contributors guides across our different repos. As he is on PTO now, I'll see if I can figure out the organizational structure.

@clyne
Copy link
Contributor

clyne commented Jun 21, 2021

@brian-rose: So, the way the old portal was built, it copied the /CONTRIBUTING.md file into the /content/pages/ directory. Are we no longer going to have a /CONTRIBUTING.md file? If we are going to keep one, then we need to make them consistent. ...So, are we going to copy /CONTRIBUTING.md into /content/pages/? Or are we going to copy the one in /content/pages/ into /? (Normally, there is a /CONTRIBUTING.md file.)

Let me check up on this. @clyne led the recent effort to consolidate the contributors guides across our different repos. As he is on PTO now, I'll see if I can figure out the organizational structure.

There is a CONTRIBUTING.md file in the foundations and landing page repo (and probably should be one in the data repo as well). This document simply provides a link back to the contributing.html document for each site. At lease it did. Things seem to have changed since I overhauled the contributor's information a week ago... Not sure what happened, and I'm headed out the door for the week.

@brian-rose
Copy link
Member

Following up on @clyne's comments:

I think our current disconnect is the for the portal site only, we currently have the detailed technical instructions for building and rendering the site ONLY in the /CONTRIBUTING.md file, with the intention that this is viewed on GitHub rather than rendered into our published site. The reason for this is that the published Contributor's Guide is meant to be a high-level guide applicable across all our repos. However this currently leaves us with a (possibly confusing) asymmetry between the Portal and the Foundations repos.

I think we could have a longer discussion about the organizational strategy. But for the sake of moving this new portal forward, this is my suggestion:

tl;dr there should be /CONTRIBUTING.md with technical details, but it is NOT copied into the rendered site because we have different content specifically designed for that.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 21, 2021

@brian-rose @clyne: Sounds good. I'll get the latest Contributor's Guide into the new portal.

@brian-rose
Copy link
Member

@brian-rose @clyne: Sounds good. I'll get the latest Contributor's Guide into the new portal.

Ok, I think this is resolved for now.

andersy005
andersy005 previously approved these changes Jun 21, 2021
@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 21, 2021

@jukent: I've tried to address your concerns in the latest commits. Let me know what you think. I think it's a decent first pass.

@jukent
Copy link
Contributor

jukent commented Jun 21, 2021

@jukent Im confused about your comment that the cards are not the same size. The demo has the cards all the same size. Can you not see it?

Oh I was referring to the demo you gave during the meeting last Thursday. In the build now it looks like the cards are all the same width, horizontally stacked, without modals, and the tag button works. I think it looks great!

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 21, 2021

@jukent Actually, some of the modals are there. 😄 Look for some of the cards that have a "...more" at the end of their description. These descriptions were cut off because of length and I added the "...more" link to open the modal. But these are the only modals that exist, now.

@jukent
Copy link
Contributor

jukent commented Jun 21, 2021

@jukent Actually, some of the modals are there. 😄 Look for some of the cards that have a "...more" at the end of their description. These descriptions were cut off because of length and I added the "...more" link to open the modal. But these are the only modals that exist, now.

I see that now! Looks great and makes sense. It's also nice knowing that the modal functionality is still there since we worked so hard on it haha (and if we decide to add more content later we still have the ability to put it in a modal easily).

@kmpaul kmpaul requested a review from andersy005 June 21, 2021 21:04
@brian-rose
Copy link
Member

@kmpaul I'm giving a talk on Pythia tomorrow for the Pangeo Showcase series. Another opportunity to get a bunch of eyes on our sites!

As I'm planning my talk, just wondering: do you anticipate being able to merge the new portal in the next 24 hours, or still working through details?

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 22, 2021

@brian-rose: Now that I have 2 approvals, I'll merge it now.

@kmpaul kmpaul merged commit 0388706 into ProjectPythia:main Jun 22, 2021
@kmpaul kmpaul deleted the new_portal branch June 22, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants