-
Notifications
You must be signed in to change notification settings - Fork 21
New Portal Landing Page #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ok, summarizing the comments so far:
Please check off the items that you feel are satisfactorily answered, and add more comments to address the ones that are not. |
Let me check up on this. @clyne led the recent effort to consolidate the contributors guides across our different repos. As he is on PTO now, I'll see if I can figure out the organizational structure. |
There is a CONTRIBUTING.md file in the foundations and landing page repo (and probably should be one in the data repo as well). This document simply provides a link back to the contributing.html document for each site. At lease it did. Things seem to have changed since I overhauled the contributor's information a week ago... Not sure what happened, and I'm headed out the door for the week. |
Following up on @clyne's comments:
I think our current disconnect is the for the portal site only, we currently have the detailed technical instructions for building and rendering the site ONLY in the I think we could have a longer discussion about the organizational strategy. But for the sake of moving this new portal forward, this is my suggestion:
tl;dr there should be |
@brian-rose @clyne: Sounds good. I'll get the latest Contributor's Guide into the new portal. |
Ok, I think this is resolved for now. |
@jukent: I've tried to address your concerns in the latest commits. Let me know what you think. I think it's a decent first pass. |
Oh I was referring to the demo you gave during the meeting last Thursday. In the build now it looks like the cards are all the same width, horizontally stacked, without modals, and the tag button works. I think it looks great! |
@jukent Actually, some of the modals are there. 😄 Look for some of the cards that have a "...more" at the end of their description. These descriptions were cut off because of length and I added the "...more" link to open the modal. But these are the only modals that exist, now. |
I see that now! Looks great and makes sense. It's also nice knowing that the modal functionality is still there since we worked so hard on it haha (and if we decide to add more content later we still have the ability to put it in a modal easily). |
@kmpaul I'm giving a talk on Pythia tomorrow for the Pangeo Showcase series. Another opportunity to get a bunch of eyes on our sites! As I'm planning my talk, just wondering: do you anticipate being able to merge the new portal in the next 24 hours, or still working through details? |
@brian-rose: Now that I have 2 approvals, I'll merge it now. |
As promised, here is the new landing page for the Portal. I've moved things around to accommodate the new page structure, and that means I had to develop some new text...and I didn't change some old text. It might be that the old text needs to be updated, too.
So, please look closely at the site and all of the contents. Read the text and determine if it makes sense and works with the new layout. Click the links and make sure they work and take you to the right place. Please look at the formatting and decide if it looks clean, the design is good, etc.