Update Jupyter Book Preview Workflow #136
Conversation
|
This pull request is being automatically built with GitHub Action + Netlify. To see the status of your deployment, click below. 🚧 Deployment in progress for git commit SHA: 96fb413 |
|
🚀 📚 Preview for git commit SHA: ca7f8ee at: https://614121e88c16cd22a2aaadd9--pythia-foundations.netlify.app |
…to deprecate-custom-action
|
🚀 📚 Preview for git commit SHA: 0b1f538 at: https://61412482ed0b051aea46d021--pythia-foundations.netlify.app |
|
🚀 📚 Preview for git commit SHA: d40b700 at: https://61412761d68fa71abf4d9851--pythia-foundations.netlify.app |
|
🚀 📚 Preview for git commit SHA: d40b700 at: https://6141276aed0b0526ab46ca96--pythia-foundations.netlify.app |
andersy005
requested review from
brian-rose and
jukent
and removed request for
a team
|
🚀 📚 Preview for git commit SHA: 96fb413 at: https://61412975c60e1f244ec1bc7a--pythia-foundations.netlify.app |
|
🚀 📚 Preview for git commit SHA: 96fb413 at: https://614129a4c60e1f25b8c1bcb9--pythia-foundations.netlify.app |
There was a problem hiding this comment.
Nice! Relying less on custom GitHub machinery seems to be a step in the right direction towards sustainability for our project. Also, fewer bot-generated comments and out of date links in each PR discussion should help keep us oriented.
I don't understand the GitHub Actions details well enough to give this a very thorough review, but I'm fine with merging this in order to see what it really does.
|
Provided I did everything right when a new PR is created, the PR is updated with this comment
Once the PR has been built, this comment is updated to
Ignore the fact that Preview URL in the screenshot is pointing to a commit SHA (It's what I had during the prototyping phase) |
|
I agree with @brian-rose This looks good to me, and I can see that it works on this PR, but I have much to learn about GitHub actions. |
|
Thank you for the review, @jukent and @brian-rose! I'm merging this and will fix any broken pieces in subsequent PRs :) |
This PR
(1) replaces the custom ProjectPythia/actions/comment-netlify-preview-in-pr GitHub action with a combination of actively maintained actions.
(2) Updates an existing comment (with a preview URL) instead of creating a new comment for each git push.
Note: This PR needs to be merged for changes in the preview-book workflow https://github.com/ProjectPythia/pythia-foundations/blob/96fb41393d79da002d376aa9a8ca5d49401db6ef/.github/workflows/preview-book.yaml to take effect...