-
Notifications
You must be signed in to change notification settings - Fork 46
Clarifying how shared colorbars are created #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: dc1e298 |
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 1a7746a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -426,11 +426,54 @@ | |||
"id": "1662bf3c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with previous comment - maybe reword to "This functionality was utilized with the previous histogram exercise"?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion - other than that, it looks great! Thanks @hCraker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!
This PR closes #276
During the recent Pythia Hacakthon, I made a cookbook explaining how to make shared colorbars in matplotlib and how to choose accessible colormaps. It was determined in the linked issue that the information in the cookbook is better suited for pythia-foundations. This PR adds information that was in the cookbook to the relevant existing sections of pythia-foundations.