Skip to content

Clarifying how shared colorbars are created #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Clarifying how shared colorbars are created #310

merged 7 commits into from
Jul 25, 2022

Conversation

hCraker
Copy link
Contributor

@hCraker hCraker commented Jul 12, 2022

This PR closes #276

During the recent Pythia Hacakthon, I made a cookbook explaining how to make shared colorbars in matplotlib and how to choose accessible colormaps. It was determined in the linked issue that the information in the cookbook is better suited for pythia-foundations. This PR adds information that was in the cookbook to the relevant existing sections of pythia-foundations.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: dc1e298
✅ Deployment Preview URL: https://62dab4a4c50ec22e7b8bd22d--pythia-foundations.netlify.app

@github-actions
Copy link

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 1a7746a
✅ Deployment Preview URL: In Progress

@hCraker hCraker marked this pull request as ready for review July 12, 2022 16:57
@hCraker hCraker requested a review from a team as a code owner July 12, 2022 16:57
@hCraker hCraker requested review from dopplershift and r-ford and removed request for a team July 12, 2022 16:57
@hCraker hCraker requested a review from r-ford July 14, 2022 20:33
Copy link
Member

@r-ford r-ford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -426,11 +426,54 @@
"id": "1662bf3c",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with previous comment - maybe reword to "This functionality was utilized with the previous histogram exercise"?


Reply via ReviewNB

Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion - other than that, it looks great! Thanks @hCraker

@hCraker hCraker requested a review from mgrover1 July 22, 2022 14:22
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matplotlib content on setting consistent colorbars
3 participants