-
Notifications
You must be signed in to change notification settings - Fork 48
Drop in Unidata matplotlib workshop notebook #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 📚 Preview for git commit SHA: 54870a5 at: https://607f4d63fcedb613bdac11da--pythia-foundations.netlify.app |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
🚀 📚 Preview for git commit SHA: f8acb0f at: https://60c246c43f93080d185cdd1b--pythia-foundations.netlify.app |
🚀 📚 Preview for git commit SHA: 28c27f0 at: https://60c272dcc3d3ef3875570fd6--pythia-foundations.netlify.app |
I'm not on the reviewers list, but I took a quick look and there's great content here! Two quick issues:
|
Looks great. I just had a few nits. |
@mgrover1 just checking in to see if you think this is still doable for wednesday. Thanks! |
Yes - sorry I will try to push the new changes today... busy with the CESM workshop this week, but I will get those changes made so you all can take a look and we can get this merged |
Coolio. Thanks! |
🚀 📚 Preview for git commit SHA: 2022cc0 at: https://60c7cbbbd73be21a19ea3998--pythia-foundations.netlify.app |
On it! FYI you can trigger a re-review whenever you are ready by clicking the circular arrows next to the reviewers names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, Max!
🚀 📚 Preview for git commit SHA: 5c50860 at: https://60c811626f2d4765312ebdab--pythia-foundations.netlify.app |
@ktyle I went ahead and fixed the spelling - thanks for the comments! |
@mgrover1 great! I think we're just about there! The only other thing I would recommend is that you de-emphasize the "exercise-like" instructions that proceed one of the last notebooks ... maybe just delete the "Try to" in the numbered item that specifies adding a colorbar. |
🚀 📚 Preview for git commit SHA: 72f3c67 at: https://60c8ab8280fb6cf783229aec--pythia-foundations.netlify.app |
🚀 📚 Preview for git commit SHA: c7210af at: https://60c8adf42601a706497433e9--pythia-foundations.netlify.app |
@ktyle I made that change |
LGTM and I think this is ready to merge ... |
@ktyle Awesome! Can you hit the approve button? |
@mgrover1 by "Approve" do you mean "Squash and merge"? |
@ktyle Sure - that or the "formal review" at the top of the page? Wasn't sure if we technically needed two approvals to merge |
Great work all! We're checking things off the milestone list... |
This is a drop-in of this notebook from Unidata's workshop materials with exercises modified and branding removed and some minor image updates. Otherwise mostly content-unmodified.
Notes: