Skip to content

What is Conda Content #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
May 28, 2021
Merged

What is Conda Content #50

merged 47 commits into from
May 28, 2021

Conversation

jukent
Copy link
Contributor

@jukent jukent commented May 12, 2021 •
edited
Loading

Branched from the "how2run" fork so contains redundant changes with #48
The new changes are in conda.md

https://hackmd.io/i4vRuiT0Rzi8_cYyzzlBog

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: e5cb3eb at: https://609bf0c171e2a4442b0688ab--pythia-foundations.netlify.app

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: d7be3c4 at: https://609bf3f0139b5172b8a1b415--pythia-foundations.netlify.app

@clyne clyne added the content Content related issue label May 12, 2021
@brian-rose
Copy link
Member

I made some edits over on hackmd

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: 1b88885 at: https://609d4d3a60035617c2019927--pythia-foundations.netlify.app

@brian-rose
Copy link
Member

I think this is good to go!

I'm working on a separate PR to update the "Quickstart" section.

@jukent jukent requested review from brian-rose, a team and dopplershift and removed request for a team May 27, 2021 19:44
brian-rose added a commit to brian-rose/pythia-foundations that referenced this pull request May 27, 2021
@brian-rose
Merge latest from ProjectPythia#50
d3721af
@brian-rose brian-rose mentioned this pull request May 27, 2021
Merged
@jukent jukent requested review from mgrover1 and removed request for dopplershift May 27, 2021 21:04
@brian-rose brian-rose requested a review from dopplershift May 27, 2021 21:04
mgrover1
mgrover1 requested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content! Just a few minor changes.

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: fb8b3b1 at: https://60b0268682bae950125e6afd--pythia-foundations.netlify.app

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: e311175 at: https://60b029171fccd14fba092e6b--pythia-foundations.netlify.app

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: beb74b6 at: https://60b02d2c8d9f436b4d917fc1--pythia-foundations.netlify.app

@jukent jukent requested a review from mgrover1 May 27, 2021 23:38
@brian-rose
Copy link
Member

Sorry I found a broken link but then couldn't help making another tweak... switching the list of conda examples from inline code to code blocks, so they render better in the book.

@brian-rose brian-rose mentioned this pull request May 28, 2021
Closed
@github-actions
Copy link

🚀 📚 Preview for git commit SHA: 13ebf21 at: https://60b0ef0cecb4df0e94c46e5b--pythia-foundations.netlify.app

@brian-rose
Copy link
Member

@mgrover1 please re-review and let us know if you're happy with @jukent's responses to your last round of suggestions. I think we can merge this as soon as you approve the changes.

mgrover1
mgrover1 approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! This looks fantastic!

@mgrover1 mgrover1 merged commit b0226d5 into ProjectPythia:main May 28, 2021
This was referenced May 28, 2021
Closed
Closed
@jukent jukent deleted the conda branch June 2, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-rose brian-rose brian-rose approved these changes

@mgrover1 mgrover1 mgrover1 approved these changes

@dopplershift dopplershift Awaiting requested review from dopplershift

Assignees
No one assigned
Labels
content Content related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jukent @brian-rose @mgrover1 @clyne @hackmd-deploy