Skip to content

Adding CSS to new domain #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

Adding CSS to new domain #2

wants to merge 27 commits into from

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Jun 27, 2022

Closes #1

@jukent
Copy link
Contributor Author

jukent commented Jun 27, 2022

Would be useful to add github actions and deployment previews

@jukent
Copy link
Contributor Author

jukent commented Jun 27, 2022

Adding extensions here, would like to refactor to not have duplicate code across repositories later.

@jukent jukent marked this pull request as ready for review June 27, 2022 20:46
@jukent jukent requested a review from kmpaul June 27, 2022 20:46
Copy link
Contributor

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use portal for the name of the directory containing the Sphinx site. And should this be a jupyter book, not a raw sphinx site?

@jukent
Copy link
Contributor Author

jukent commented Jun 27, 2022

I wouldn't use portal for the name of the directory containing the Sphinx site. And should this be a jupyter book, not a raw sphinx site?

Why should this be a Jupyterbook? The only page in this repository is the "index" generated from the cookbook_gallery_generator. I was confused for a while deciding to use the infrastructure from the portal or from the foundations book. The portal seemed like it would play with the gallery generator better (since that is how it worked before).

There were so many moving parts, I wouldn't be surprised if I missed anything.

@jukent jukent requested review from kmpaul, brian-rose and clyne June 27, 2022 21:29
Copy link
Contributor

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the site/_build directory being committed to this repo? That should be in the gitignore file.

@jukent
Copy link
Contributor Author

jukent commented Jun 27, 2022

Why is the site/_build directory being committed to this repo? That should be in the gitignore file.

Ahh I thought I missed the "portal" to "cookbooks" to "site" transition somewhere.

@jukent jukent requested a review from kmpaul June 27, 2022 22:01
@kmpaul
Copy link
Contributor

kmpaul commented Jun 28, 2022

@jukent: The new Cookbook organization contains a fork of this repository. So, you don't have to move all of your work to that repo. You can just merge this PR into this repo as usual, and then we can merge new changes from this repo into the Cookbooks fork. Once this PR is merged, we can "detach" the Cookbooks fork from this repo and the two will be independent.

@kmpaul kmpaul reopened this Jun 28, 2022
@kmpaul
Copy link
Contributor

kmpaul commented Jun 28, 2022

@jukent: Why did you close this?

@jukent
Copy link
Contributor Author

jukent commented Jun 28, 2022

@kmpaul Oops @jnmorley and I just started the process already -- and in doing so I deleted this repo and it closed the PR. It will be ready/. The new PR will be opened very soon.

@kmpaul
Copy link
Contributor

kmpaul commented Jun 28, 2022

We don't want to delete this repo!

@kmpaul
Copy link
Contributor

kmpaul commented Jun 28, 2022

So, you cannot delete this repo because the ProjectPythiaCookbooks/projectpythiacookbooks.github.io repo is a fork of this repo! Just keep working on your PR here, merge it, and we can pull the changes into the cookbooks repo.

@jukent
Copy link
Contributor Author

jukent commented Jun 28, 2022

So, you cannot delete this repo because the ProjectPythiaCookbooks/projectpythiacookbooks.github.io repo is a fork of this repo! Just keep working on your PR here, merge it, and we can pull the changes into the cookbooks repo.

I deleted my own fork of it (where the PR is coming from).

I made a new PR here ProjectPythia/cookbook-gallery#3

@kmpaul
Copy link
Contributor

kmpaul commented Jun 28, 2022

Well, we want a site for the Tutorials org, too. So, keeping this PR, merging it, and then pulling those changes into the Cookbooks repo would have killed 2 birds with 1 stone.

We'll have to merge from the Cookbooks repo back into this repo when ProjectPythia/cookbook-gallery#3 gets merged, then.

@jukent
Copy link
Contributor Author

jukent commented Jun 28, 2022

Sorry. I got frustrated that GitHub wouldn't let me have a fork of both the tutorials and cookbooks repositories since they are forked from each other. I cannot undo the deletion of my fork by making a new one (since I made one in the cookbooks repo) but we can still merge this PR as is.

@kmpaul
Copy link
Contributor

kmpaul commented Jun 28, 2022

If you are going to merge ProjectPythia/cookbook-gallery#3 in, then let me know. Once that is merged, I'll merge that into this repo and start working on the tutorials org site myself. You can keep working on the Cookbooks site.

@kmpaul
Copy link
Contributor

kmpaul commented Jun 28, 2022

That means we'll just have to close this PR.

@kmpaul kmpaul closed this Jun 28, 2022
@jukent
Copy link
Contributor Author

jukent commented Jun 28, 2022

Okay thanks I'll merge it now

@jukent
Copy link
Contributor Author

jukent commented Jun 28, 2022

Done!

@jukent
Copy link
Contributor Author

jukent commented Jun 28, 2022

I figured out the error with the teams -- they need to be added to each repository with write permission, not just created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Cookbook Gallery here?
2 participants