Er suggestions nonmfs #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominguesgm
reviewed
Oct 9, 2019
src/tutorials/0005/02.md
Outdated
Comment on lines
9
to
11
| ## Uploading files in the exercise | ||
|
|
||
| As we will be working with adding files to and getting files from an IPFS node, we will need some files to experiment with. For this purpose, there is an upload file step in each code exercise of this tutorial. |
There was a problem hiding this comment.
@ericronne do you think we should remove this? Given this would be a begginer-oriented tutorial, I think it would be useful to explain the file upload functionality of the coding exercise
There was a problem hiding this comment.
Sure, good call @dominguesgm 👍
dominguesgm
approved these changes
Oct 10, 2019
dominguesgm
pushed a commit
that referenced
this pull request
Oct 11, 2019
* Title renaming for parallelism * Copy suggestions - lesson 1 * Lesson 1 edits * Lesson 2 edits * Lesson 3 edits * Lessons 4-6 edits * chore: update to review * chore: restore section on file upload in lesson 2 * chore: worked on last comment left
dominguesgm
pushed a commit
that referenced
this pull request
Oct 11, 2019
* Title renaming for parallelism * Copy suggestions - lesson 1 * Lesson 1 edits * Lesson 2 edits * Lesson 3 edits * Lessons 4-6 edits * chore: update to review * chore: restore section on file upload in lesson 2 * chore: worked on last comment left
terichadbourne
pushed a commit
that referenced
this pull request
Nov 6, 2019
* feat: first draft of first lesson * feat: draft of the second lesson done. also bumped ipfs version * feat: first draft of the 3rd lesson * chore: first draft of the 4th lesson * chore: first draft of the 5th lesson * feat: first draft of 6th and last lesson * chore: revisit lesson 2: change information on add method argument * Er suggestions nonmfs (#304) * Title renaming for parallelism * Copy suggestions - lesson 1 * Lesson 1 edits * Lesson 2 edits * Lesson 3 edits * Lessons 4-6 edits * chore: update to review * chore: restore section on file upload in lesson 2 * chore: worked on last comment left * chore: made several revisions from feedback. missing discussion on directories and simplifying lesson 7 * copy edits to lesson 1 * copy edits to lesson 2 * copy edits to lesson 3 * fix typos * remove old comments from Vue files * add MFS tutorial to resources page * update featured courses * fix typo * copy edits to lesson 4 * chore: update approach to lesson 5 * chore: update lesson 6 to match lesson 5 * chore: added content to lesson 5 * copy edits to Lesson 5k * fix tutorial path * add IPFS Camp course to resources * fix: fixed bug causing race conditions on fast executing user code * copy edits to lesson 6 * add resulting code block sample to L6 * chore: added lesson on cat file inside directory * copy edits to lesson 7 * feat: improved lessons 7 and 8 Note: success.txt is now inside a subdirectory * feat: made some improvements to lesson 5 * lesson 7 copy edits * copy edit to lesson 5 success msg * lesson 8 copy edits, adding ls comparison * fix merge issue * update references to Regular Files API * update tutorial description * fix: lesson 1: add format for mfs files API method calls * fix copy paste errors * mention IPLD when describing DAG API * change tutorial url * chore: minor changes * chore: update with most of the changes suggested by Alan * Use ipfs in path in src/tutorials/0005/07.md Co-Authored-By: Marcin Rataj <[email protected]> * Apply suggestions from code review Co-Authored-By: Marcin Rataj <[email protected]> * add /ipfs/ to paths * incorporate feedback from Alan & Marcin * chore: change main solution in lesson 05 * chore: updated file structure and contents * chore: update src/tutorials/0005/07-exercise.md Co-Authored-By: Marcin Rataj <[email protected]> * chore: updated validation for lessons 3, 4, and 5. Fixed a bug in validation of lesson 10 in the MFS tutorial * chore: update to lesson 6 validation * chore: update feedback on lesson 7 * chore: update lesson 8 validation * remove all references to 'root' directory * imrpove catch-all error msg * tweaks to error messages * move javascript hints from solution to hints in exercise * chore: update validation for lessons 5 and 7 according to comments * validation tweaks + new override * rename variable * minor copy edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled a branch from @dominguesgm's work in order to encapsulate all of my editorial thoughts. Hopefully this tack doesn't complicate things too much. Note that i interjected some asides here and there, eg when i wasn't clear on the intent of a phrase or sentence. I'll extract those once resolved.
My hidden agenda with all of the protoschool material i attempt to edit is to learn, and i'm happy to say that this experience was educational (as always). So thanks for helping me learn something new!