Expose DISPLAYMATRIX side data #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2023 11:56
added 2 commits
December 19, 2023 13:41
|
Looks good. I don't it makes sense to put a docstring on a internal method so removed it. I also removed using the SideData object in cdef code because it's slower than comparing the int directly. |
This was referenced Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to get DISPLAYMATRIX side data as part of the video stream attribute
It solves this issue.
While
SideDatais only populated withDISPLAYMATRIXso far, one could easily add other side data in future PR and query them via_get_side_data.All tests are passing locally