-
Notifications
You must be signed in to change notification settings - Fork 23
Introduce Y022/Y023/Y024/Y025: Imports linting error codes #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Okay, should be ready for review now. I'll hold off running a codemodding script on the Python-2 parts of typeshed until people have had a chance to review :) |
Co-authored-by: Jelle Zijlstra <[email protected]>
I will get codemodding tomorrow! |
Typeshed PR to make the CI go green: TODO:
|
Ohhhh I hardcoded Y019 to look for |
flake8 is complaining that |
Actually, I'll leave it for now, since I might be refactoring that function anyway. |
A second typeshed PR to try to get the CI green is here: python/typeshed#6954 |
...And a third typeshed PR: python/typeshed#6955 |
CI is finally green, and I think I've addressed the points @Akuli raised (just two dicts now, and managed to get rid of the icky quotes-within-quotes everywhere). Re-requesting review from you, @JelleZijlstra, if that's okay, as it's changed a fair bit since when you approved it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed. No red flags.
Thanks! |
Helps work towards #80 and #32. I've tried to keep these error codes completely cross-compatible between Python 2 and Python 3 -- I think it would be best to leave Python-3-only changes (e.g. disallowing
typing.ContextManager
andtyping_extensions.OrderedDict
) can be left for another error code.