Add whitespace checks for match and case

[cdce8p]

E271 multiple spaces after keyword and E275 missing whitespace after keyword should also also be emitted for match and case. However, since they are only soft keywords, some additional logic is needed.

If accepted and the next version is released, this check could be added to flake8 as well (flake8/setup.cfg).

[asottile]

I would prefer if the existing checks were extended (this will provide better compatibility and performance)

[cdce8p]

That was my initial idea. However, at least AFAIK it isn't that simple. As example, the best place would probably have been the whitespace_around_keywords check. The issue there is that it also checks for whitespace before the keyword and that match and case are only soft keywords.

It might make sense to rename the new check to something like whitespace_around_soft_keywords. That would at least provide options to extend it in the future.

pycodestyle/pycodestyle.py

Lines 473 to 494 in 61138ca

	@register_check
	def whitespace_around_keywords(logical_line):
	r"""Avoid extraneous whitespace around keywords.
	Okay: True and False
	E271: True and False
	E272: True and False
	E273: True and\tFalse
	E274: True\tand False
	"""
	for match in KEYWORD_REGEX.finditer(logical_line):
	before, after = match.groups()
	if '\t' in before:
	yield match.start(1), "E274 tab before keyword"
	elif len(before) > 1:
	yield match.start(1), "E272 multiple spaces before keyword"
	if '\t' in after:
	yield match.start(2), "E273 tab after keyword"
	elif len(after) > 1:
	yield match.start(2), "E271 multiple spaces after keyword"

[asottile]

I don't see why you can't add it to the bottom of the code you've linked? renaming or adding functions leads to a bunch of annoying issues created by operating system distributors that intentionally and erroneously violate dependency constraints so I'd really like to avoid adding / renaming functions when possible

[cdce8p]

Ok, done.

[asottile]

[asottile]

this caused #1024 -- I'm just going to revert this for now -- we can potentially add it back later