[#1332451] Add an error for return outside of function. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks. The reason these errors aren't already caught is that pyflakes parses, but does not compile the code. See #8. |
bitglue
added a commit
that referenced
this pull request
Feb 14, 2015
[#1332451] Add an error for return outside of function.
This was referenced May 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See: https://bugs.launchpad.net/pyflakes/+bug/1332451
The code on master was already ignoring this error and no longer crashing.
Changes
Create a dedicated errror but not sure if this is needed as it is already raised by python as a syntax error.
Check that changes make sense of just close this pull request and the Launchpad ticket.
Thanks!