Skip to content

Add new example showing how to use ndarray's parallel and blas-src features #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

adamreichold
Copy link
Member

Fixes #70
Fixes #71

@adamreichold adamreichold force-pushed the parallel-example branch 3 times, most recently from 0f08a3f to 7ddfa53 Compare January 9, 2022 21:23
@adamreichold
Copy link
Member Author

adamreichold commented Jan 17, 2022

Planning to merge this today as it does not really touch production code, but improves CI and Clippy handling and closes two long standing issues.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, looks great to me! Sorry for the continual delays; I've had a large backlog recently.

Just one comment on what looks like an unused dependency?

Apart from that, please do merge this 👍

@@ -0,0 +1,21 @@
extern crate blas_src;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like blas_src is used?

Copy link
Member Author

@adamreichold adamreichold Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is actually necessary as the resulting cdylib otherwise does not link to BLAS. https://github.com/rust-ndarray/ndarray#how-to-enable-blas-integration has the details.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add a comment with this link to the example.

@adamreichold adamreichold merged commit ab2d214 into main Jan 17, 2022
@adamreichold adamreichold deleted the parallel-example branch January 17, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support blas Example extension with ndarray_parallel
2 participants