Support converting Array1<usize> #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
approved these changes
Jun 13, 2019
src/types.rs
Outdated
| cfg_if! { | ||
| if #[cfg(all(target_pointer_width = "64", windows))] { | ||
| impl_type_num!(usize, Uint64, NPY_ULONGLONG); | ||
| } else if #[cfg(all(target_pointer_width = "64", not (windows)))] { |
There was a problem hiding this comment.
I think we this(not (windows) space is redundunt
src/types.rs
Outdated
| impl_type_num!(usize, Uint64, NPY_ULONG, NPY_ULONGLONG); | ||
| } else if #[cfg(all(target_pointer_width = "32", windows))] { | ||
| impl_type_num!(usize, Uint32, NPY_UINT, NPY_ULONG); | ||
| } else if #[cfg(all(target_pointer_width = "32", not (windows)))] { |
|
Thanks for your PR! |
|
Thanks for the review @kngwyu ! Formatting should be fixed now. |
|
Thanks, again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, trying to convert e.g. an
Array1<usize>to Python fails due to the conversion not being implemented forusizedtype.I tried to add it following the suggestion in rust-ndarray/ndarray#493 (comment)
If I understand correctly, usize should map to either
np.uint32ornp.uint64depending on the architecture.