Skip to content

Canonicalize base executable path when finding interpreter #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

Canonicalize base executable path when finding interpreter #435

merged 1 commit into from
Jun 5, 2024

Conversation

matsjoyce-refeyn
Copy link
Contributor

Port across the change from PyO3/maturin#2100 (based on #429 (comment)) which allows this improvement to work with Poetry (thanks @messense!).

davidhewitt
davidhewitt approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@davidhewitt davidhewitt merged commit d7868df into PyO3:main Jun 5, 2024
39 checks passed
@matsjoyce-refeyn matsjoyce-refeyn deleted the resolve-base-executable-path branch June 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matsjoyce-refeyn @messense @davidhewitt